Define size of table in px rather than em
#845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-845
|
I don't think this is a breaking (major) change. The height of a table is not 'known' – it's entirely dependant on the content within it. I can't really see how someone would be using tables in such a way that changing that height of the table (especially by such a small amount) makes any meaningful difference. |
This mirrors the changes made in #491
hannalaakso
force-pushed
the
remove-em-from-tables
branch
from
63eaea7 to
7588601
Compare
|
Agreed. I've changed the Changelog entry and filed this under Fixes. |
kr8n3r
approved these changes
Jul 6, 2018
36degrees
approved these changes
Jul 9, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the changes made in #491. The change to tables was omitted from that PR as it wasn't clear whether there was an accessibility consideration for using
emfor tables in Elements but @selfthinker has said that this doesn't appear to be the case.As discussed with @dashouse, the change in this PR does very slightly increase the padding of cells on mobile viewport as the use of
emmeant the font size set in the table was used to calculate padding.topandbottomof cells increase by 1.5px which slightly increases the height of the table on mobile. (padding-rightalso increases very slightly but it won't change the width of the table).